Images refresh batch 2 #2541

lidiazuin · 2025-08-15T11:50:17Z

No description provided.

…neo4j#2490) Since we moved them over from DBMS level (while still keeping the DBMS level syntax, just as another syntax for `DATABASE *`) --------- Co-authored-by: Mark Dixon <[email protected]> Co-authored-by: Reneta Popova <[email protected]>

The Operations manual covers all releases of 2025.xx series. That's why we cannot simply replace examples with new ones, as new functionality has been added. We also need to retain examples for earlier versions of Neo4j.

modules/ROOT/images/privileges-hierarchy-database.svg

NataliaIvakina · 2025-08-28T09:12:35Z

On the page Database privileges, Figure 2. Syntax of GRANT and DENY database privileges is not updated.
Is this expected?

NataliaIvakina · 2025-08-28T09:15:16Z

On the page DBMS privileges, the Figure 1. Syntax of GRANT and DENY DBMS privileges is not updated.
The same question -- is this expected?

modules/ROOT/images/privileges-hierarchy-dbms.svg

NataliaIvakina · 2025-08-28T10:09:03Z

modules/ROOT/images/privileges-hierarchy-dbms.svg

I think, the branch (on the right hand side) for SERVER MANAGEMENT -> SHOW SERVERS, EXECUTE Privileges, and SHOW SETTINGS privilege is unclear and might be wrong.
There are three equal groups:

SERVER MANAGEMENT (with SHOW SERVERS at the 2nd level),

EXECUTE PRIVILEGES (that include EXECUTE PROCEDURES, EXECUTE BOOSTED PROCEDURES, EXECUTE ADMIN(ISTRATOR) PROCEDURES, EXECUTE FUNCTIONS, and EXECUTE BOOSTED FUNCTIONS),

and SHOW SETTINGS.

I think, we should have three equal branches for them. At the moment, their hierarchy is unclear.

The EXECUTE privileges aren't a group in the hierarchy: they don't have a common parent privilege.

They are included under ALL DBMS PRIVILEGES as that one includes EXECUTE FUNCTION, EXECUTE BOOSTED FUNCTION, EXECUTE PROCEDURE and EXECUTE BOOSTED PROCEDURE for all functions and procedures (which therefore also covers the EXECUTE ADMIN PROCEDURES as that one includes EXECUTE PROCEDURE and EXECUTE BOOSTED PROCEDURE but only for procedures marked as admin procedures). So the old image that currently exist in the documentation is correct to have them just on a line and not in a group, as the 'groups' are actual privileges themselves.

NataliaIvakina · 2025-08-28T10:17:10Z

modules/ROOT/images/privileges-hierarchy-dbms.svg

What if to make frames of the first level blocks bold? These blocks are:

ROLE MANAGEMENT

USER MANAGEMENT

IMPERSONATE

SERVER MANAGEMENT

DATABASE MANAGEMENT

ALIAS MANAGEMENT

PRIVILEGE MANAGEMENT

EXECUTE PRIVILEGES (I think they could be grouped together)

SHOW SETTINGS

NataliaIvakina · 2025-08-28T14:58:23Z

modules/ROOT/pages/authentication-authorization/dbms-administration.adoc

@@ -76,7 +76,7 @@ For more details on the differences between graphs, databases, and the DBMS, ref

 image::privileges_grant_and_deny_syntax_dbms_privileges.svg[width="800", title="Syntax of GRANT and DENY DBMS privileges"]


image::privileges-grant-and-deny-syntax-dbms-privileges.svg[width="800", title="Syntax of GRANT and DENY DBMS privileges"]

NataliaIvakina · 2025-08-28T15:04:03Z

modules/ROOT/pages/authentication-authorization/database-administration.adoc

@@ -480,7 +480,7 @@ GRANT [IMMUTABLE] TRANSACTION [MANAGEMENT] [( { * \| user[, ...] } )]
 |===


-image::privileges_grant_and_deny_syntax_database_privileges.svg[title="Syntax of GRANT and DENY Database Privileges"]
+image::privileges-grant-and-deny-syntax-database-privileges.svg[title="Syntax of GRANT and DENY Database Privileges", role=popup]


I don't understand what is happening here. In line 187, image::privileges_hierarchy_database.svg[title="Database privileges hierarchy"] is used instead of the new file name with hyphens. However, the new image is rendered in the preview.

The file name is updated in the line 483, but the old image is rendered.

Hunterness · 2025-08-29T13:02:07Z

modules/ROOT/images/privileges-hierarchy-dbms.svg

I feel like the blocks are hard to read and the hierarchy structure is harder to see with this layout :(

(I assume this applies to more than just this one of the hierarchy pictures but I only opened this one so far)

~~it looks better in the preview than here on github though 🤷~~

modules/ROOT/images/privileges-grant-and-deny-syntax-database-privileges.svg

renetapopova

Thank you, @lidiazuin. They all look good from a visual perspective but I've found some inconsistencies and things that might lead to misunderstandings.

renetapopova · 2025-09-08T11:05:54Z

modules/ROOT/images/privileges-hierarchy-database.svg

Alter database is missing

#2541 (comment) I also noticed this :P

modules/ROOT/pages/authentication-authorization/database-administration.adoc

renetapopova · 2025-09-08T11:17:31Z

modules/ROOT/images/privileges-grant-and-deny-syntax-dbms-privileges.svg

I think some of your image comments doesn't load?

renetapopova · 2025-09-08T11:48:07Z

modules/ROOT/images/privileges-hierarchy-dbms.svg

The connections that you noted that don't derive from the same place are all coming from ALL DBMS PRIVILEGES, that's the style of the arrows used in the technical diagrams. I can try to change the style, but just letting you know that this is the default styling.

I thought so, but they look misleading, so I decided to tell you if you can change them somehow.

modules/ROOT/pages/authentication-authorization/load-privileges.adoc

modules/ROOT/pages/authentication-authorization/dbms-administration.adoc

renetapopova · 2025-09-08T11:52:44Z

modules/ROOT/images/privileges-grant-and-deny-syntax-load-privileges.svg

There is no space between To role and [,...] in the original diagram. @Hunterness, is the space a problem?

I don't think it matters as such but generally I'd not have a space there if I write the command even if it parses (... TO role1, role2 vs ... TO role1 , role2) 🤷

I'll also say that if the other syntax images doesn't have the space I don't think we should have it here but be consistent about it

renetapopova · 2025-09-08T12:06:23Z

modules/ROOT/images/privileges-hierarchy.svg

Co-authored-by: Reneta Popova <[email protected]>

Hunterness

Review of current state

Status (to help me keep track): 3 open comments

modules/ROOT/images/privileges-grant-and-deny-syntax-database-privileges.svg

Hunterness · 2025-09-10T14:13:34Z

modules/ROOT/images/privileges-grant-and-deny-syntax-dbms-privileges.svg

the database bubble looks empty, it should contain a lot of things not just alter database:

So most things seems to have been readded but ALTER DATABASE is still missing (between DROP DATABASE and SET DATABASE ACCESS)

Still missing ALTER DATABASE (between DROP DATABASE and SET DATABASE ACCESS)

modules/ROOT/images/privileges-hierarchy-dbms.svg

modules/ROOT/images/privileges-grant-and-deny-syntax-load-privileges.svg

modules/ROOT/pages/authentication-authorization/manage-privileges.adoc

Hunterness · 2025-09-10T14:46:36Z

modules/ROOT/images/privileges-hierarchy.svg

I like that this one have arrows, I'd like the other hierarchy ones to also have that

modules/ROOT/images/privileges-hierarchy.svg

modules/ROOT/pages/kubernetes/quickstart-standalone/server-setup.adoc

modules/ROOT/images/privileges-hierarchy-dbms.svg

modules/ROOT/images/privileges-hierarchy.svg

modules/ROOT/pages/kubernetes/quickstart-standalone/server-setup.adoc

neo4j-docops-agent · 2025-09-15T13:20:16Z

This PR includes documentation updates
View the updated docs at https://neo4j-docs-operations-2541.surge.sh

Updated pages:

Hunterness

Next round of comments, a lot of them on missing/to much bold :P

Hunterness · 2025-09-16T06:13:10Z

modules/ROOT/images/privileges-grant-and-deny-syntax-database-privileges.svg

The TO in TO role[, ...] should not be bold...

Hunterness · 2025-09-16T06:13:34Z

modules/ROOT/images/privileges-grant-and-deny-syntax-database-privileges.svg

Also, I don't know if I like having the input parts being bold, the italics was more subtle when comparted to the regular text of the keywords. This is why I initially suggested that the keywords were put in bold to still have them be the stronger of the two, if that makes sense

Can you make the keywords bold? that could also separate the keywords and input if keywords are bold and input not

If we decide to switch so keywords are bold and input not, then all of my comments on which parts of which bubbles need to be updated to be bold/not-bold need to also be inverted as they follow the current version where input is bold

Hunterness · 2025-09-16T06:15:04Z

modules/ROOT/images/privileges-grant-and-deny-syntax-database-privileges.svg

The *|user[, ...] bubble after the transaction privileges should still have () as that is part of the syntax

Hunterness · 2025-09-16T06:17:01Z

modules/ROOT/images/privileges-grant-and-deny-syntax-dbms-privileges.svg

The *|user[, ...] bubble after IMPERSONATE should still have () as it's part of syntax

Hunterness · 2025-09-16T06:17:28Z

modules/ROOT/images/privileges-grant-and-deny-syntax-dbms-privileges.svg

The TO in TO role[, ...] should not be bold...

Hunterness · 2025-09-16T06:49:23Z

modules/ROOT/images/privileges-on-graph-syntax.svg

pattern should be bold

Hunterness · 2025-09-16T06:49:41Z

modules/ROOT/images/privileges-on-graph-syntax.svg

the TO in TO role[, ...] should not be bold

Hunterness · 2025-09-16T07:23:32Z

modules/ROOT/images/privileges-grant-and-deny-syntax-dbms-privileges.svg

the name-globbing[, ...] should be bold

Hunterness · 2025-09-16T07:31:12Z

modules/ROOT/images/privileges-hierarchy-dbms.svg

Before all the second level privileges came in the same/consistent order between the groups: create x, drop x, rename x, alter x, assign x, remove x, sub-management privilege, show x (of course only listing the sub-privileges they had)

But here the order isn't as consistent: take the role and user ones for example, they have SHOW in different places in their order

Hunterness · 2025-09-16T07:32:10Z

modules/ROOT/images/privileges-hierarchy-dbms.svg

For the sub-privileges of ALTER USER, it would be nice to have SET PASSWORD[S] and SET AUTH next to each other as they are related (both have to do with auth of the user)

Images refresh batch 2

399a3a6

lidiazuin requested review from renetapopova and NataliaIvakina August 15, 2025 11:50

lidiazuin added the cherry-pick-this-to-main label Aug 15, 2025

lidiazuin and others added 6 commits August 15, 2025 13:50

Merge branch 'dev' into imgrefresh-batch2

86a6ef6

Update the description of the history option (neo4j#2543)

fc82a2d

Add tabbed examples for multiple node IDs (neo4j#2512)

fe668fb

The Operations manual covers all releases of 2025.xx series. That's why we cannot simply replace examples with new ones, as new functionality has been added. We also need to retain examples for earlier versions of Neo4j.

Images refresh batch 2

879932c

Merge branch 'dev' into imgrefresh-batch2

bfb7692

NataliaIvakina reviewed Aug 28, 2025

View reviewed changes

modules/ROOT/images/privileges-hierarchy-database.svg Outdated Show resolved Hide resolved

NataliaIvakina reviewed Aug 28, 2025

View reviewed changes

modules/ROOT/images/privileges-hierarchy-dbms.svg Outdated Show resolved Hide resolved

NataliaIvakina reviewed Aug 28, 2025

View reviewed changes

modules/ROOT/images/privileges-hierarchy-dbms.svg Outdated Show resolved Hide resolved

NataliaIvakina reviewed Aug 28, 2025

View reviewed changes

reviewed images after feedback

3a9c6f0

NataliaIvakina reviewed Aug 28, 2025

View reviewed changes

review after feedback

ed698cb

Hunterness reviewed Aug 29, 2025

View reviewed changes

Hunterness reviewed Sep 1, 2025

View reviewed changes

modules/ROOT/images/privileges-grant-and-deny-syntax-database-privileges.svg Outdated Show resolved Hide resolved

lidiazuin and others added 3 commits September 1, 2025 15:47

Merge branch 'dev' into imgrefresh-batch2

41136da

update of image

50c621f

update image after review

dbb011c

renetapopova requested changes Sep 8, 2025

View reviewed changes

lidiazuin and others added 3 commits September 10, 2025 15:10

first updates after review (more to come)

c8dd59e

Merge branch 'dev' into imgrefresh-batch2

f11978f

Apply suggestions from code review

1da63da

Co-authored-by: Reneta Popova <[email protected]>

lidiazuin requested review from renetapopova and Hunterness September 10, 2025 13:14

Hunterness reviewed Sep 10, 2025

View reviewed changes

updated images after review

73f9704

Hunterness reviewed Sep 15, 2025

View reviewed changes

modules/ROOT/images/privileges-hierarchy-dbms.svg Outdated Show resolved Hide resolved

modules/ROOT/images/privileges-hierarchy.svg Outdated Show resolved Hide resolved

modules/ROOT/pages/kubernetes/quickstart-standalone/server-setup.adoc Show resolved Hide resolved

lidiazuin and others added 2 commits September 15, 2025 15:17

updated images after review

f2e0f5c

Merge branch 'dev' into imgrefresh-batch2

afb9893

Hunterness reviewed Sep 16, 2025

View reviewed changes

		@@ -76,7 +76,7 @@ For more details on the differences between graphs, databases, and the DBMS, ref

		image::privileges_grant_and_deny_syntax_dbms_privileges.svg[width="800", title="Syntax of GRANT and DENY DBMS privileges"]

Images refresh batch 2 #2541

Are you sure you want to change the base?

Images refresh batch 2 #2541

Uh oh!

Conversation

lidiazuin commented Aug 15, 2025

Uh oh!

Uh oh!

NataliaIvakina commented Aug 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

NataliaIvakina commented Aug 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

NataliaIvakina Aug 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

NataliaIvakina Aug 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Hunterness Aug 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Hunterness Sep 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

renetapopova left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

renetapopova Sep 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

renetapopova Sep 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

renetapopova Sep 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Hunterness left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

NataliaIvakina commented Aug 28, 2025 •

edited

Loading

NataliaIvakina commented Aug 28, 2025 •

edited

Loading

NataliaIvakina Aug 28, 2025 •

edited

Loading

NataliaIvakina Aug 28, 2025 •

edited

Loading

Hunterness Aug 29, 2025 •

edited

Loading

Hunterness Sep 1, 2025 •

edited

Loading

renetapopova Sep 8, 2025 •

edited

Loading

renetapopova Sep 8, 2025 •

edited

Loading

renetapopova Sep 8, 2025 •

edited

Loading

Hunterness left a comment •

edited

Loading